Upstream tracking #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm locking the discussion on this PR, since it is never intended to merge, and only serve as a standing comparison. |
Previously, if you don't have Internet connectivity, tab completion might try to fetch the flake registry, e.g. $ NIX_GET_COMPLETIONS=4 nix build -vvvvv --offline /home/eelco/De evaluating file '<nix/derivation-internal.nix>' downloading 'https://channels.nixos.org/flake-registry.json'... warning: error: unable to download 'https://channels.nixos.org/flake-registry.json': Could not resolve hostname (6) Could not resolve host: channels.nixos.org; retrying in 294 ms warning: error: unable to download 'https://channels.nixos.org/flake-registry.json': Could not resolve hostname (6) Could not resolve host: channels.nixos.org; retrying in 541 ms warning: error: unable to download 'https://channels.nixos.org/flake-registry.json': Could not resolve hostname (6) Could not resolve host: channels.nixos.org; retrying in 1230 ms warning: error: unable to download 'https://channels.nixos.org/flake-registry.json': Could not resolve hostname (6) Could not resolve host: channels.nixos.org; retrying in 2285 ms warning: error: unable to download 'https://channels.nixos.org/flake-registry.json': Could not resolve hostname (6) Could not resolve host: channels.nixos.org; using cached version
Tagging release 2.30.2
Co-authored-by: Cole Helbling <[email protected]>
…hing Avoid isValidPath(), use queryPathInfo() instead
…n-detsys Imply --offline during tab completion
SQLite: fsync db.sqlite-shm before opening the database
Make GitFileSystemObjectSink multi-threaded
Sync with upstream 2.30.2
Adding paths to the store can be slow due to I/O overhead, but especially when going through the daemon because of the round-trip latency of every wopAddToStore call. So we now do the addToStore() calls asynchronously from a separate thread from the evaluator. This slightly speeds up the local store, and makes going through the daemon almost as fast as a local store.
Add paths to the store asynchronously
Remove obsolete FIXME
This change brings our Determinate Nix source repository in line with our standard branch naming.
One reason we used detsys-main was to avoid confusion in case the upstream NixOS/nix repository changed its default branch to main.
I don't anticipate that happening any time soon if ever, and so let's make the change.
Having this repo have a different branch name has a non-zero cost for humans ("oh right, different branch") and code to account for it.
Since we're shifting to internally run from `trunk()` (hi, jj) in more places, it's a "do it or don't" moment.
I choose to do it.
Rename detsys-main to main
|
Upstream tracking continues here: #165 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Not intended to be merged directly. This PR is a convenience to show the diff between upstream Nix and Determinate Nix (the
detsys-mainbranch).Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.